CC @iwanders and @inner-daemons for the knowledge spread. 😄

This is on me, I told them to add the leading slash because I assumed we didn't create any other target directories.

Given that I doubt people will be symlinking the target directories in xtask, I wonder if we should just use:

/target
target/

That way, we cover symlinking the root target directory and don't regress other target directories, while still allowing files named "target"?

Also, does this cover naga's xtask?

Also, @ErichDonGubler, it's the holidays! You've earned a break from working on wgpu lol, though your time is very much appreciated

Hopefully this is the only crate that's independent of the workspace? 🤞

That way, we cover symlinking the root target directory and don't regress other target directories, while still allowing files named "target"?

That would probably address the majority of usecases? When I manually write the .gitignore I usually just type target, which ensures that the build artifacts in crates not part of the workspace are also ignored. That does not match target.rs, but it would of course match a module directory called target, which would not be an unexpected name for the target of a rendering pipeline or something... I'm sorry this became such a rabbit hole 😅

Thanks for addressing this @ErichDonGubler, the branch name made me chuckle btw :D

I think it's pretty reasonable to expect any other main-workspace-independent crates to add their own .gitignore with /target, so I don't think we need a target/ rule specifically. OTOH, if anybody feels strongly about it, I don't expect it'll cause significant problems to add target/.

@iwanders:

Thanks for addressing this @ErichDonGubler, the branch name made me chuckle btw :D

Fun fact: You can find the source for this here:

https://github.com/erichdongubler-dotfiles/nushell/blob/61e46c9de3ba160280a115fc51cb3cb6d79ac024/scripts/erichdongubler/jj.nu#L177-L184

🤦‍♂️ I didn't even check that lmao. I assumed at least naga xtask would use a separate cargo due to being run from a different root folder but it seems cargo is still smart enough to use the root target. Unless someone is actually experiencing this issue probably this can be closed

Ahhh, derp, the target/ folder I was reacting to was left over from my previous development of xtask before it got added to the workspace. Closing!